CHANGE: Deprecate useIMGUIEditorForAssets #2283

K-Tone · 2025-11-14T14:42:37Z

Description

Here we deprecate the useIMGUIEditorForAssets feature flag.

The aim is to reduce total variability caused by having to keep code that can work both ways - with uitk and without. We've had the uitk code running for a while now, and with the minimum supported Editor being 22.3 TLS we no longer have to care about the case when uitk wasn't available.

Testing status & QA

Local testing

Overall Product Risks

Complexity: Low
Halo Effect: Low

Checklist

Before review:

Changelog entry added.
- Explains the change in Changed, Fixed, Added sections.
- For API change contains an example snippet and/or migration example.
- JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
- Jira port for the next release set as "Resolved".
Tests added/changed, if applicable.
- Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
- Performance tests.
- Integration tests.
Docs for new/changed API's.
- Xmldoc cross references are set correctly.
- Added explanation how the API works.
- Usage code examples added.
- The manual is updated, if needed.

During merge:

Commit message for squash-merge is prefixed with one of the list:
- NEW: ___.
- FIX: ___.
- DOCS: ___.
- CHANGE: ___.
- RELEASE: 1.1.0-preview.3.

u-pr-agent · 2025-11-14T14:44:44Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪ The PR touches many files, but the changes are highly repetitive and consist of removing obsolete IMGUI code paths, making the review straightforward.
🏅 Score: 95 The PR provides a great and systematic cleanup by deprecating and removing old IMGUI code. A minor typo was found.
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Typo There's a typo in the constant string variable `tolltip`. It should be `tooltip`. private const string tolltip = "Determine which axis 'wins' if both are actuated at the same time. "
Update review

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent

Packages/com.unity.inputsystem/InputSystem/Actions/Composites/AxisComposite.cs

Packages/com.unity.inputsystem/InputSystem/Actions/Composites/Vector2Composite.cs

codecov-git.colasdn.top · 2025-11-14T14:53:21Z

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...com.unity.inputsystem/InputSystem/InputSettings.cs	25.00%	3 Missing ⚠️
...putSystem/Actions/Interactions/PressInteraction.cs	0.00%	2 Missing ⚠️
...em/InputSystem/Actions/Composites/AxisComposite.cs	0.00%	1 Missing ⚠️
...InputSystem/Actions/Composites/Vector2Composite.cs	0.00%	1 Missing ⚠️
...InputSystem/Actions/Composites/Vector3Composite.cs	0.00%	1 Missing ⚠️
...System/Actions/Interactions/MultiTapInteraction.cs	0.00%	1 Missing ⚠️

@@             Coverage Diff             @@
##           develop    #2283      +/-   ##
===========================================
+ Coverage    76.81%   77.63%   +0.81%     
===========================================
  Files          476      474       -2     
  Lines        88726    87896     -830     
===========================================
+ Hits         68155    68236      +81     
+ Misses       20571    19660     -911

Flag	Coverage Δ
inputsystem_MacOS_2021.3	`?`
inputsystem_MacOS_2021.3_project	`?`
inputsystem_MacOS_2022.3	`5.54% <0.00%> (+0.15%)`	⬆️
inputsystem_MacOS_2022.3_project	`75.49% <7.14%> (+0.79%)`	⬆️
inputsystem_MacOS_6000.0	`5.32% <0.00%> (+0.14%)`	⬆️
inputsystem_MacOS_6000.0_project	`77.41% <35.71%> (+0.80%)`	⬆️
inputsystem_MacOS_6000.2	`5.32% <0.00%> (+0.14%)`	⬆️
inputsystem_MacOS_6000.2_project	`77.41% <35.71%> (+0.81%)`	⬆️
inputsystem_MacOS_6000.3	`5.32% <0.00%> (+0.14%)`	⬆️
inputsystem_MacOS_6000.3_project	`77.40% <35.71%> (+0.80%)`	⬆️
inputsystem_MacOS_6000.4	`5.33% <0.00%> (+0.14%)`	⬆️
inputsystem_MacOS_6000.4_project	`77.42% <35.71%> (+0.80%)`	⬆️
inputsystem_MacOS_6000.5	`5.33% <0.00%> (+0.14%)`	⬆️
inputsystem_MacOS_6000.5_project	`77.41% <35.71%> (+0.80%)`	⬆️
inputsystem_Ubuntu_2021.3	`?`
inputsystem_Ubuntu_2021.3_project	`?`
inputsystem_Ubuntu_2022.3	`5.55% <0.00%> (+0.15%)`	⬆️
inputsystem_Ubuntu_2022.3_project	`75.29% <7.14%> (+0.79%)`	⬆️
inputsystem_Ubuntu_6000.0	`5.33% <0.00%> (+0.14%)`	⬆️
inputsystem_Ubuntu_6000.0_project	`77.21% <35.71%> (+0.80%)`	⬆️
inputsystem_Ubuntu_6000.2	`5.33% <0.00%> (+0.14%)`	⬆️
inputsystem_Ubuntu_6000.2_project	`77.21% <35.71%> (+0.81%)`	⬆️
inputsystem_Ubuntu_6000.3	`5.33% <0.00%> (+0.14%)`	⬆️
inputsystem_Ubuntu_6000.3_project	`77.21% <35.71%> (+0.80%)`	⬆️
inputsystem_Ubuntu_6000.4	`5.33% <0.00%> (+0.14%)`	⬆️
inputsystem_Ubuntu_6000.4_project	`77.22% <35.71%> (+0.80%)`	⬆️
inputsystem_Ubuntu_6000.5	`5.33% <0.00%> (+0.14%)`	⬆️
inputsystem_Ubuntu_6000.5_project	`77.22% <35.71%> (+0.81%)`	⬆️
inputsystem_Windows_2021.3	`?`
inputsystem_Windows_2021.3_project	`?`
inputsystem_Windows_2022.3	`5.54% <0.00%> (+0.15%)`	⬆️
inputsystem_Windows_2022.3_project	`75.62% <7.14%> (+0.80%)`	⬆️
inputsystem_Windows_6000.0	`5.32% <0.00%> (+0.14%)`	⬆️
inputsystem_Windows_6000.0_project	`77.53% <35.71%> (+0.80%)`	⬆️
inputsystem_Windows_6000.2	`5.32% <0.00%> (+0.14%)`	⬆️
inputsystem_Windows_6000.2_project	`77.53% <35.71%> (+0.81%)`	⬆️
inputsystem_Windows_6000.3	`5.32% <0.00%> (+0.14%)`	⬆️
inputsystem_Windows_6000.3_project	`77.53% <35.71%> (+0.80%)`	⬆️
inputsystem_Windows_6000.4	`5.33% <0.00%> (+0.14%)`	⬆️
inputsystem_Windows_6000.4_project	`77.54% <35.71%> (+0.81%)`	⬆️
inputsystem_Windows_6000.5	`5.33% <0.00%> (+0.14%)`	⬆️
inputsystem_Windows_6000.5_project	`77.54% <35.71%> (+0.81%)`	⬆️
linux_2021.3_pkg	`?`
linux_2021.3_project	`?`
linux_2022.3_pkg	`?`
linux_2022.3_project	`?`
linux_6000.0_pkg	`?`
linux_6000.0_project	`?`
linux_6000.1_pkg	`?`
linux_6000.1_project	`?`
linux_6000.2_pkg	`?`
linux_6000.2_project	`?`
linux_trunk_pkg	`?`
linux_trunk_project	`?`
mac_2021.3_pkg	`?`
mac_2021.3_project	`?`
mac_2022.3_pkg	`?`
mac_2022.3_project	`?`
mac_6000.0_pkg	`?`
mac_6000.0_project	`?`
mac_6000.1_pkg	`?`
mac_6000.1_project	`?`
mac_6000.2_pkg	`?`
mac_6000.2_project	`?`
mac_trunk_pkg	`?`
mac_trunk_project	`?`
win_2021.3_pkg	`?`
win_2021.3_project	`?`
win_2022.3_pkg	`?`
win_2022.3_project	`?`
win_6000.0_pkg	`?`
win_6000.0_project	`?`
win_6000.1_pkg	`?`
win_6000.1_project	`?`
win_6000.2_pkg	`?`
win_6000.2_project	`?`
win_trunk_pkg	`?`
win_trunk_project	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
Assets/Tests/InputSystem/CoreTests_Actions.cs	`97.78% <ø> (+<0.01%)`	⬆️
Assets/Tests/InputSystem/CoreTests_Analytics.cs	`99.27% <ø> (-0.02%)`	⬇️
...nputSystem/Actions/Interactions/HoldInteraction.cs	`72.09% <ø> (+4.70%)`	⬆️
...tSystem/Actions/Interactions/SlowTapInteraction.cs	`54.83% <ø> (+4.83%)`	⬆️
...InputSystem/Actions/Interactions/TapInteraction.cs	`71.73% <ø> (+4.39%)`	⬆️
...ystem/Controls/Processors/AxisDeadzoneProcessor.cs	`51.72% <ø> (+4.84%)`	⬆️
...stem/Controls/Processors/StickDeadzoneProcessor.cs	`62.16% <ø> (+4.66%)`	⬆️
...InputSystem/Editor/Analytics/InputBuildAnalytic.cs	`77.52% <ø> (-0.74%)`	⬇️
...nputSystem/Editor/AssetEditor/ParameterListView.cs	`48.23% <100.00%> (+8.15%)`	⬆️
...Editor/UITKAssetEditor/InputActionsEditorWindow.cs	`49.65% <ø> (+0.33%)`	⬆️
... and 7 more

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Assets/Samples/CustomComposite/CustomComposite.cs

Packages/com.unity.inputsystem/InputSystem/Actions/Composites/AxisComposite.cs

Packages/com.unity.inputsystem/InputSystem/Editor/Analytics/InputBuildAnalytic.cs

Packages/com.unity.inputsystem/InputSystem/Editor/AssetEditor/ParameterListView.cs

Packages/com.unity.inputsystem/InputSystem/InputSettings.cs

ekcoh

Great to see another review cleaning things up! Good work.

Assets/Samples/CustomComposite/CustomComposite.cs

Packages/com.unity.inputsystem/CHANGELOG.md

Packages/com.unity.inputsystem/InputSystem/Editor/Analytics/InputBuildAnalytic.cs

ekcoh · 2025-11-19T10:45:46Z

Packages/com.unity.inputsystem/InputSystem/Editor/AssetEditor/ParameterListView.cs

-        private GUIContent[] m_ParameterLabels;
+
+        // .Item1 is text, .Item2 is tooltip
+        private Tuple<string, string>[] m_ParameterLabels;


Might this even be ValueTuple to reduce object allocation?

Packages/com.unity.inputsystem/InputSystem/Editor/AssetEditor/ParameterListView.cs

Packages/com.unity.inputsystem/InputSystem/InputSettings.cs

ekcoh

Marking this as "request changes" only for sake of typo in identifier name.

Packages/com.unity.inputsystem/CHANGELOG.md

Packages/com.unity.inputsystem/InputSystem/Actions/Composites/Vector2Composite.cs

Packages/com.unity.inputsystem/InputSystem/Actions/Composites/AxisComposite.cs

…gether

This reverts commit 718c23b.

…hod altogether" This reverts commit 5c56992.

Co-authored-by: Håkan Sidenvall <[email protected]>

ekcoh

Thanks for making adoptions. It was small but I do not see why we should introduce shadowing scope risks / warnings when we do not have to.

K-Tone · 2025-11-20T10:00:07Z

CC @Pauliusd01 for viz, there should be next to no functional changes really

K-Tone marked this pull request as ready for review November 14, 2025 14:43

K-Tone changed the title ~~Anthony/deprecate useimguiforassets~~ CHANGE: Deprecate useIMGUIEditorForAssets Nov 14, 2025

u-pr-agent bot reviewed Nov 14, 2025

View reviewed changes

Packages/com.unity.inputsystem/InputSystem/Actions/Composites/AxisComposite.cs Outdated Show resolved Hide resolved

Packages/com.unity.inputsystem/InputSystem/Actions/Composites/Vector2Composite.cs Outdated Show resolved Hide resolved

K-Tone requested a review from ekcoh November 18, 2025 09:50